Page MenuHomePhabricator
Differential D9284

Move email verification into PhabricatorUserEditor
ClosedPublic
Actions

Authored by epriestley on May 24 2014, 11:08 PM.
Tags
None
Referenced Files
F14033648: D9284.diff
Sat, Nov 9, 6:55 PM
F13993079: D9284.diff
Tue, Oct 22, 8:32 PM
F13989149: D9284.id22048.diff
Mon, Oct 21, 6:26 PM
F13986725: D9284.id.diff
Mon, Oct 21, 5:05 AM
Unknown Object (File)
Fri, Oct 11, 9:48 AM
Unknown Object (File)
Oct 1 2024, 3:20 PM
Unknown Object (File)
Sep 25 2024, 1:08 PM
Unknown Object (File)
Sep 20 2024, 6:41 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP83112cc2e8c7: Move email verification into PhabricatorUserEditor
Summary

Both email verify and welcome links now verify email, centralize them and record them in the user activity log.

Test Plan
  • Followed a "verify email" link and got verified.
  • Followed a "welcome" (verifying) link.
  • Followed a "reset" (non-verifying) link.
  • Looked in the activity log for the verifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22048.May 24 2014, 11:08 PM
epriestley retitled this revision from to Move email verification into PhabricatorUserEditor.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 24 2014, 11:08 PM
Harbormaster completed remote builds in B691: Diff 22048.May 24 2014, 11:09 PM
btrahan accepted this revision.Jun 3 2014, 9:54 PM
btrahan edited edge metadata.

awesometown

(nothing like a little cleanup in the email verification flow)

This revision is now accepted and ready to land.Jun 3 2014, 9:54 PM
epriestley closed this revision.Jun 3 2014, 11:45 PM
epriestley updated this revision to Diff 22318.

Closed by commit rP83112cc2e8c7 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
15 lines
16 lines
people/
editor/
59 lines
storage/
2 lines

Diff 22318

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorEmailVerificationController.php

Loading...
View Options

src/applications/people/editor/PhabricatorUserEditor.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserLog.php

Loading...
Phabricator · Built by Phacility