Page MenuHomePhabricator
Differential D9284

Move email verification into PhabricatorUserEditor
ClosedPublic
Actions

Authored by epriestley on May 24 2014, 11:08 PM.
Tags
None
Referenced Files
F13818291: D9284.diff
Fri, Sep 20, 6:41 AM
Unknown Object (File)
Sun, Sep 15, 1:48 PM
Unknown Object (File)
Wed, Sep 4, 4:47 PM
Unknown Object (File)
Sun, Sep 1, 4:35 PM
Unknown Object (File)
Thu, Aug 29, 9:36 PM
Unknown Object (File)
Wed, Aug 21, 11:54 AM
Unknown Object (File)
Aug 9 2024, 9:31 AM
Unknown Object (File)
Aug 5 2024, 12:45 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP83112cc2e8c7: Move email verification into PhabricatorUserEditor
Summary

Both email verify and welcome links now verify email, centralize them and record them in the user activity log.

Test Plan
  • Followed a "verify email" link and got verified.
  • Followed a "welcome" (verifying) link.
  • Followed a "reset" (non-verifying) link.
  • Looked in the activity log for the verifications.

Diff Detail

Repository
rP Phabricator
Branch
rauth1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 691
Build 691: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22048.May 24 2014, 11:08 PM
epriestley retitled this revision from to Move email verification into PhabricatorUserEditor.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 24 2014, 11:08 PM
Harbormaster completed remote builds in B691: Diff 22048.May 24 2014, 11:09 PM
btrahan accepted this revision.Jun 3 2014, 9:54 PM
btrahan edited edge metadata.

awesometown

(nothing like a little cleanup in the email verification flow)

This revision is now accepted and ready to land.Jun 3 2014, 9:54 PM
epriestley closed this revision.Jun 3 2014, 11:45 PM
epriestley updated this revision to Diff 22318.

Closed by commit rP83112cc2e8c7 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
15 lines
16 lines
people/
editor/
59 lines
storage/
2 lines

Diff 22048

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorEmailVerificationController.php

Loading...
View Options

src/applications/people/editor/PhabricatorUserEditor.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserLog.php

Loading...
Phabricator · Built by Phacility