Project - add ability to select an icon for typeaheads and such
ClosedPublic
Actions

Authored by btrahan on May 23 2014, 12:30 AM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5090: Allow projects to change their icon in typeaheads

Commits

Restricted Diffusion Commit
rP102befdede3a: Project - add ability to select an icon for typeaheads and such

Summary

Fixes T5090. Introduced getIcon into Handle stack which allows you to specify a per handle icon. getIcon falls back ot getTypeIcon.

Test Plan

changed the icon on a project a bunch. verified transactions showed up. verified icon showed up in typeahead. verified icon showed up in tokens that were pre-generated (not typed in). units test passed.

Diff Detail

Repository

rP Phabricator

Branch

T5090

Lint

Lint Skipped

Unit

Tests Passed

Build Status

Buildable 662
Build 662: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 22001.May 23 2014, 12:30 AM

btrahan added a task: T5090: Allow projects to change their icon in typeaheads.

btrahan retitled this revision from to Project - add ability to select an icon for typeaheads and such.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptMay 23 2014, 12:30 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B662: Diff 22001.May 23 2014, 12:32 AM

Screen_Shot_2014-05-22_at_5.32.36_PM.png (1×1 px, 597 KB)

Screen_Shot_2014-05-22_at_5.32.39_PM.png (1×1 px, 538 KB)

Screen_Shot_2014-05-22_at_5.32.51_PM.png (1×1 px, 622 KB)

Screen_Shot_2014-05-22_at_5.32.24_PM.png (1×1 px, 364 KB)

Screen_Shot_2014-05-22_at_5.32.18_PM.png (1×1 px, 364 KB)

awwyiss

src/applications/project/controller/PhabricatorProjectEditIconController.php
34	stray phlog

This revision is now accepted and ready to land.May 23 2014, 12:36 AM

chad added inline comments.May 23 2014, 12:38 AM

src/applications/project/controller/PhabricatorProjectEditMainController.php
100	might be too clever, but what about having this be the actual icon it's set to currently?
src/applications/project/icon/PhabricatorProjectIcon.php
8	probably want one for mailing-list, maybe instead of pholder?

We could add another row -- fa-envelope ("Communication"), fa-truck ("Release"), fa-lock ("Policy") and fa-umbrella ("An Umbrella") maybe?

epriestley awarded a token.May 23 2014, 12:42 AM

In D9264#12, @epriestley wrote:

We could add another row -- fa-envelope ("Communication"), fa-truck ("Release"), fa-lock ("Policy") and fa-umbrella ("An Umbrella") maybe?

I concur, doctor.

remove the phlog
add the 4th row
be clever and have the icon be the current icon (qrcode / any icon I could find to convey the meaning is pretty piss poor given the "edit picture" action, so I like the clever idea for now.)

Harbormaster completed remote builds in B663: Diff 22002.May 23 2014, 1:17 AM