Paths

Table of Contentst

Fix "arc linters" if no engine is built or configured
ClosedPublic
Actions

Authored by epriestley on May 22 2014, 3:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 12:01 AM

	Unknown Object (File)
	Fri, Dec 20, 9:17 PM

	Unknown Object (File)
	Mon, Dec 16, 11:21 AM

	Unknown Object (File)
	Sun, Dec 15, 4:50 PM

	Unknown Object (File)
	Sun, Dec 15, 5:13 AM

	Unknown Object (File)
	Wed, Dec 11, 3:12 PM

	Unknown Object (File)
	Tue, Dec 10, 6:12 PM

	Unknown Object (File)
	Thu, Dec 5, 7:45 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

rARCf64dee022e92: Fix "arc linters" if no engine is built or configured

Summary

$engine will be undefined here. This was just copy/paste derp, combined with me accidentally having an .arclint file in a place I didn't expect to have one when I tried to test this.

Test Plan

Ran arc linters in a totally bare, non-.arclint-having working copy

Diff Detail

Repository

rARC Arcanist

Branch

linters

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 649
Build 649: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21972.May 22 2014, 3:13 PM

epriestley retitled this revision from to Fix "arc linters" if no engine is built or configured.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 22 2014, 3:13 PM

Harbormaster completed remote builds in B649: Diff 21972.May 22 2014, 3:14 PM

btrahan accepted this revision.May 22 2014, 4:42 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 22 2014, 4:42 PM

Closed by commit rARCf64dee022e92 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLintersWorkflow.php

2 lines

Diff 21972

View Options

src/workflow/ArcanistLintersWorkflow.php

Fix "arc linters" if no engine is built or configuredClosedPublicActions