Fix warning in `arc backout`
ClosedPublic
Actions

Authored by epriestley on May 21 2014, 7:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 6:59 AM

	Unknown Object (File)
	Sun, Dec 15, 5:13 AM

	Unknown Object (File)
	Sun, Dec 8, 8:45 PM

	Unknown Object (File)
	Sat, Dec 7, 4:42 PM

	Unknown Object (File)
	Wed, Dec 4, 8:57 PM

	Unknown Object (File)
	Wed, Dec 4, 8:57 PM

	Unknown Object (File)
	Wed, Dec 4, 8:57 PM

	Unknown Object (File)
	Wed, Dec 4, 8:40 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T5145: `arc backout` may hit undefined index

Commits

rARC07895c41c706: Fix warning in `arc backout`

Summary

Fixes T5145. Neither variable is ever used.

Test Plan

Searched for uses of either variable.

Diff Detail

Repository

rARC Arcanist

Branch

backout

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 637
Build 637: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21955.May 21 2014, 7:50 PM

epriestley retitled this revision from to Fix warning in `arc backout`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5145: `arc backout` may hit undefined index.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 21 2014, 7:50 PM

Harbormaster completed remote builds in B637: Diff 21955.May 21 2014, 7:51 PM

btrahan accepted this revision.May 21 2014, 7:54 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 21 2014, 7:54 PM

Closed by commit rARC07895c41c706 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBackoutWorkflow.php

3 lines

Diff 21955

View Options

src/workflow/ArcanistBackoutWorkflow.php

Fix warning in `arc backout`ClosedPublicActions