Page MenuHomePhabricator
Differential D9238

Allow dashboard panel policies to be edited
ClosedPublic
Actions

Authored by lpriestley on May 21 2014, 5:38 PM.
Tags
None
Referenced Files
F19504128: D9238.diff
Fri, Jan 9, 3:38 AM
F19354100: D9238.id21942.diff
Fri, Dec 26, 5:53 AM
F19194970: D9238.id21943.diff
Dec 16 2025, 12:03 PM
F19155485: D9238.id21943.diff
Dec 12 2025, 3:35 AM
F19092374: D9238.id21942.diff
Dec 3 2025, 5:28 PM
F19092373: D9238.id21941.diff
Dec 3 2025, 5:28 PM
F19092372: D9238.id21943.diff
Dec 3 2025, 5:28 PM
F19058107: D9238.id.diff
Nov 29 2025, 12:46 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4982: Allow dashboard Panel view and edit policies to be configured
Commits
Restricted Diffusion Commit
rP953f95054f60: Allow dashboard panel policies to be edited
Summary

Fixes T4982, expose dashboard panel policy editing to UI

Test Plan

Create panel, verify that user can edit who can see and who can edit panel

Diff Detail

Repository
rP Phabricator
Branch
editdashboardpanelpolicy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 629
Build 629: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 21941.May 21 2014, 5:38 PM
lpriestley retitled this revision from to Allow dashboard panel policies to be edited.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4982: Allow dashboard Panel view and edit policies to be configured.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 5:38 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B629: Diff 21941.May 21 2014, 5:39 PM
epriestley requested changes to this revision.May 21 2014, 5:41 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
112–113

I think these should be $panel, not $credential.

(I'm surprised lint doesn't catch this, I'll see if I can fix the rule.)

src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
90–95

Hmm, I don't expect this part to be necessary. Can you walk me through what this fixes?

This revision now requires changes to proceed.May 21 2014, 5:41 PM
lpriestley added inline comments.May 21 2014, 5:46 PM
src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
112–113

copy pasta

lpriestley updated this revision to Diff 21942.May 21 2014, 5:47 PM
lpriestley edited edge metadata.

Removing unnecessary code and fixing copy/paste surplus

Harbormaster completed remote builds in B630: Diff 21942.May 21 2014, 5:48 PM
epriestley accepted this revision.May 21 2014, 5:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 21 2014, 5:48 PM
epriestley closed this revision.May 21 2014, 5:48 PM
epriestley updated this revision to Diff 21943.

Closed by commit rP953f95054f60 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

Diff 21941

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php

Loading...
Phabricator · Built by Phacility