Page MenuHomePhabricator
Differential D9230

Replace action sprite with FontAwesome
ClosedPublic
Actions

Authored by chad on May 21 2014, 3:40 AM.
Tags
None
Referenced Files
F15410877: D9230.diff
Wed, Mar 19, 8:37 AM
F15340879: D9230.diff
Sun, Mar 9, 5:25 PM
Unknown Object (File)
Sat, Mar 1, 2:22 AM
Unknown Object (File)
Sat, Mar 1, 2:16 AM
Unknown Object (File)
Mon, Feb 24, 11:49 AM
Unknown Object (File)
Mon, Feb 24, 10:47 AM
Unknown Object (File)
Thu, Feb 20, 6:25 PM
Unknown Object (File)
Feb 18 2025, 3:26 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPac05fe9c3b77: Replace action sprite with FontAwesome
Summary

Replaces the action icons in action headers with FontAwesome

Test Plan
  • grep SPRITE_ACTIONS
  • grep sprite-actions
  • Replace on UIExamples
  • Replace on Workboards
  • Replace on Dashboards
  • Replace on FeedStories

undefined (372×512 px, 48 KB)

undefined (299×670 px, 54 KB)

Diff Detail

Repository
rP Phabricator
Branch
sprite-actions
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 618
Build 618: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21924.May 21 2014, 3:40 AM
chad retitled this revision from to Replace action sprite with FontAwesome.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 21 2014, 3:40 AM
Harbormaster completed remote builds in B618: Diff 21924.May 21 2014, 3:41 AM
chad edited the test plan for this revision. (Show Details)May 21 2014, 3:42 AM
epriestley accepted this revision.May 21 2014, 5:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 21 2014, 5:07 PM
chad closed this revision.May 21 2014, 5:18 PM
chad updated this revision to Diff 21937.

Closed by commit rPac05fe9c3b77 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
sprite/
manifest/
scripts/
celerity/
1 line
src/
applications/
conpherence/
controller/
3 lines
dashboard/
engine/
6 lines
project/
controller/
3 lines
uiexample/
examples/
9 lines
24 lines
21 lines
infrastructure/
celerity/
61 lines
view/
layout/
52 lines
phui/
2 lines
3 lines
webroot/
rsrc/
css/
font/
11 lines
layout/
9 lines
phui/
3 lines
9 lines
image/

Diff 21924

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/manifest/actions.json

Loading...
View Options

scripts/celerity/generate_sprites.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceWidgetController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/uiexample/examples/PHUIFeedStoryExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIIconExample.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorActionHeaderExample.php

Loading...
View Options

src/infrastructure/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/view/layout/PhabricatorActionHeaderView.php

Loading...
View Options

src/view/phui/PHUIIconView.php

Loading...
View Options

src/view/phui/PHUIWorkpanelView.php

Loading...
View Options

webroot/rsrc/css/font/phui-font-icon-base.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-action-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-feed-story.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/sprite-actions.css

Loading...
View Options

webroot/rsrc/image/sprite-actions-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-actions.png

Loading...
Phabricator · Built by Phacility