Page MenuHomePhabricator

Fix binary/utf8 issues with Differential changeset parse cache
ClosedPublic

Authored by epriestley on May 17 2014, 11:24 PM.
Tags
None
Referenced Files
F17837678: D9171.diff
Sat, Jul 26, 5:41 PM
F17627728: D9171.id.diff
Thu, Jul 10, 6:44 AM
Unknown Object (File)
Jun 15 2025, 8:52 PM
Unknown Object (File)
Jun 15 2025, 11:12 AM
Unknown Object (File)
Jun 14 2025, 4:22 PM
Unknown Object (File)
Jun 9 2025, 2:17 AM
Unknown Object (File)
May 27 2025, 6:07 PM
Unknown Object (File)
May 10 2025, 9:39 PM
Subscribers

Details

Summary

Fixes T4898. After we increased the strictness of the %s conversion, most serialize() output is rejected from the cache.

Drop the cache, change the column type to latin1_bin, and then use %B to mark the data as binary during query construction.

Test Plan

Viewed Differential, saw cache fills.

Diff Detail

Repository
rP Phabricator
Branch
dxbincache
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 537
Build 537: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix binary/utf8 issues with Differential changeset parse cache.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, sophiebits.
src/applications/differential/parser/DifferentialChangesetParser.php
369

YES INDEED

sophiebits edited edge metadata.

yay for catching things. also caching stuff.

This revision is now accepted and ready to land.May 17 2014, 11:30 PM
epriestley updated this revision to Diff 21786.

Closed by commit rPd744d5d85995 (authored by @epriestley).