Give audits a clickable commit title, even if they are importing or messageless
ClosedPublic
Actions

Authored by epriestley on May 17 2014, 10:04 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP28c198d9026e: Give audits a clickable commit title, even if they are importing or messageless

Summary

Fixes T3854. Subversion allows commits with no message, and in other cases we might not have imported the message yet. In these cases, we may not render any text inside the link.

When we hit these cases, render appropriate replacement text.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21779.May 17 2014, 10:04 PM

epriestley retitled this revision from to Give audits a clickable commit title, even if they are importing or messageless.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 17 2014, 10:04 PM

Harbormaster completed remote builds in B534: Diff 21779.May 17 2014, 10:06 PM

chad accepted this revision.May 17 2014, 10:20 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 17 2014, 10:20 PM

Closed by commit rP28c198d9026e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

view/

PhabricatorAuditListView.php

34 lines

Diff 21781

View Options

src/applications/audit/view/PhabricatorAuditListView.php

Give audits a clickable commit title, even if they are importing or messagelessClosedPublicActions