Page MenuHomePhabricator
Differential D9091

Rename "stableCommitName" to "stableCommit"
ClosedPublic
Actions

Authored by epriestley on May 13 2014, 12:17 PM.
Tags
None
Referenced Files
F14839516: D9091.id21630.diff
Fri, Jan 31, 11:24 PM
Unknown Object (File)
Tue, Jan 28, 9:28 AM
Unknown Object (File)
Tue, Jan 28, 7:51 AM
Unknown Object (File)
Sun, Jan 26, 10:12 PM
Unknown Object (File)
Sat, Jan 18, 6:30 AM
Unknown Object (File)
Fri, Jan 17, 10:19 PM
Unknown Object (File)
Fri, Jan 17, 8:36 PM
Unknown Object (File)
Tue, Jan 14, 5:25 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2683: Improve the performance of Diffusion browse views
Commits
Restricted Diffusion Commit
rP9a2c68fd8848: Rename "stableCommitName" to "stableCommit"
Summary

Ref T2683. This is closely related to "symbolicCommit", but has an inconsistent "name" on the end.

Also, diffusion.searchquery uses this parameter inconsistently.

Test Plan
  • greped for callsites.
  • Ran searches in Git and Mercurial repositories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21599.May 13 2014, 12:17 PM
epriestley retitled this revision from to Rename "stableCommitName" to "stableCommit".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2683: Improve the performance of Diffusion browse views.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 13 2014, 12:17 PM
Harbormaster completed remote builds in B421: Diff 21599.May 13 2014, 12:18 PM
epriestley updated this revision to Diff 21602.May 13 2014, 12:31 PM
  • One missing call.
Harbormaster completed remote builds in B424: Diff 21602.May 13 2014, 12:33 PM
btrahan accepted this revision.May 13 2014, 4:08 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 13 2014, 4:08 PM
epriestley closed this revision.May 13 2014, 8:51 PM
epriestley updated this revision to Diff 21630.

Closed by commit rP9a2c68fd8848 (authored by @epriestley).

Revision Contents
Changeset List

Diff 21630

View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_readmequery_Method.php

Loading...
View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_searchquery_Method.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseMainController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseSearchController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionChangeController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/diffusion/request/DiffusionSvnRequest.php

Loading...
Phabricator · Built by Phacility