Paths

Table of Contentst

Read 'phabricator.uri' and 'default' out of more config sources
ClosedPublic
Actions

Authored by epriestley on May 13 2014, 6:31 PM.

Tags

None

Referenced Files

	F14402250: D9105.id21622.diff
	Sun, Dec 22, 11:59 PM

	Unknown Object (File)
	Mon, Dec 16, 2:51 AM

	Unknown Object (File)
	Fri, Dec 13, 6:16 PM

	Unknown Object (File)
	Wed, Dec 11, 11:10 PM

	Unknown Object (File)
	Wed, Dec 11, 10:51 PM

	Unknown Object (File)
	Sun, Dec 8, 2:28 AM

	Unknown Object (File)
	Thu, Dec 5, 1:01 PM

	Unknown Object (File)
	Wed, Dec 4, 10:45 AM

View All Files

Subscribers

davedash

epriestley

Details

Reviewers

btrahan
davedash

Commits

rARC85b6c581e11b: Read 'phabricator.uri' and 'default' out of more config sources

Summary

We have old/inconsistent code for reading these. Instead, read from sources in a modern way.

Test Plan

Removed "default" and "phabricator.uri" from user/local/project config.
Set "default" in "/etc/arcconfig".
Ran arc tasks and got a "connect to Phabricator" message.

Diff Detail

Repository

rARC Arcanist

Branch

default

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 439
Build 439: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21621.May 13 2014, 6:31 PM

epriestley retitled this revision from to Read 'phabricator.uri' and 'default' out of more config sources.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 13 2014, 6:31 PM

Specifically, "default" and "phabricator.uri" currently have no effect in system configuration.

Harbormaster completed remote builds in B439: Diff 21621.May 13 2014, 6:32 PM

Looks good to me.

This revision is now accepted and ready to land.May 13 2014, 6:36 PM

Closed by commit rARC85b6c581e11b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

arcanist.php

10 lines

Diff 21621

View Options

Read 'phabricator.uri' and 'default' out of more config sourcesClosedPublicActions