Page MenuHomePhabricator

Remove `shouldCreateDiffusionRequest` from Diffusion conduit methods
ClosedPublic

Authored by epriestley on May 13 2014, 12:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 3, 9:32 AM
Unknown Object (File)
Fri, Jan 31, 2:57 AM
Unknown Object (File)
Tue, Jan 28, 8:13 AM
Unknown Object (File)
Fri, Jan 17, 4:46 PM
Unknown Object (File)
Thu, Jan 16, 11:26 AM
Unknown Object (File)
Mon, Jan 13, 11:48 AM
Unknown Object (File)
Jan 8 2025, 2:30 PM
Unknown Object (File)
Jan 3 2025, 1:30 AM
Subscribers

Details

Summary

Ref T2683. This has no callsites, and the functionality is covered by the initFromConduit flag.

This simplifies the code and reduces then number of internal diffusion.resolverefs calls we make on, e.g., the Git repository page from 7 to 2.

Test Plan

Grepped for these symbols.

Diff Detail

Repository
rP Phabricator
Branch
resolv1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 420
Build 420: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove `shouldCreateDiffusionRequest` from Diffusion conduit methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

long live initFromConduit

This revision is now accepted and ready to land.May 13 2014, 4:07 PM
epriestley updated this revision to Diff 21629.

Closed by commit rP7cc9720d6096 (authored by @epriestley).