Did a more exhaustive grep on setIcon and found 99.9% of the icons.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rP0120388a7516: Found some missing icons
I verified icon names on UIExamples, but unable to test some of the more complex flows visually. Mostly a read and replace.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- fa-icons
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 416 Build 416: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think my long term plan is to have maybe 20-30 icon constants, that way we lock common 'start, stop, history, edit, create, new, etc' as there are many choices.