Page MenuHomePhabricator
Differential D9049

Make sure READMEs can hit the markup cache in Diffusion
ClosedPublic
Actions

Authored by epriestley on May 11 2014, 1:07 AM.
Tags
None
Referenced Files
F14033428: D9049.id21574.diff
Sat, Nov 9, 5:38 PM
F14033427: D9049.id21554.diff
Sat, Nov 9, 5:38 PM
F14033426: D9049.id21490.diff
Sat, Nov 9, 5:38 PM
F14033425: D9049.id.diff
Sat, Nov 9, 5:38 PM
F14020559: D9049.diff
Wed, Nov 6, 12:44 AM
F14008601: D9049.id21574.diff
Wed, Oct 30, 2:03 AM
F14008600: D9049.id21554.diff
Wed, Oct 30, 2:03 AM
F14008599: D9049.id21490.diff
Wed, Oct 30, 2:03 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5028: Commit message text formatting in remote git repository (SSH) is not preserved
T2683: Improve the performance of Diffusion browse views
Commits
Restricted Diffusion Commit
rPcfa265f02091: Make sure READMEs can hit the markup cache in Diffusion
Summary

Ref T2683. Normally not a big deal, but if a readme has some codeblocks missing the cache can slow things down.

Test Plan
  • Verified we hit the cache.
  • Verified TOC still works.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21490.May 11 2014, 1:07 AM
epriestley retitled this revision from to Make sure READMEs can hit the markup cache in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2683: Improve the performance of Diffusion browse views.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 11 2014, 1:07 AM
Harbormaster completed remote builds in B358: Diff 21490.May 11 2014, 1:09 AM
epriestley updated this revision to Diff 21554.May 12 2014, 2:27 PM
epriestley added a task: T5028: Commit message text formatting in remote git repository (SSH) is not preserved.
  • Ref T5028. Don't preserve linebreaks when marking up READMEs that we interpret as remarkup.
Harbormaster completed remote builds in B399: Diff 21554.May 12 2014, 2:28 PM
btrahan accepted this revision.May 12 2014, 6:29 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 6:29 PM
epriestley closed this revision.May 12 2014, 6:49 PM
epriestley updated this revision to Diff 21574.

Closed by commit rPcfa265f02091 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
31 lines
repository/
graphcache/
9 lines
infrastructure/
markup/
5 lines
14 lines

Diff 21574

View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_readmequery_Method.php

Loading...
View Options

src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupOneOff.php

Loading...
Phabricator · Built by Phacility