Add config to require real name, respect config when creating new users, drop real name from full name if not provided.
ClosedPublic
Actions

Authored by lpriestley on May 9 2014, 5:06 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4728: Make real name optional on user accounts

Commits

Restricted Diffusion Commit
rPdfcccd4cb882: Add config to require real name, respect config when creating new users, drop…

Summary

Fixes T4728, first pass, Make real name optional on user accounts

Test Plan

Default real name config should be false (not required). Create new user, real name should not be required. Toggle config, real name should be required. Users with no real name should be always listed by their usernames.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lpriestley updated this revision to Diff 21440.May 9 2014, 5:06 PM

lpriestley retitled this revision from to Add config to require real name, respect config when creating new users, drop real name from full name if not provided..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4728: Make real name optional on user accounts.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 9 2014, 5:06 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B325: Diff 21440.May 9 2014, 5:07 PM

Switching double negative

Harbormaster completed remote builds in B326: Diff 21441.May 9 2014, 5:10 PM

This looks great -- two small tweaks inline.

src/applications/people/config/PhabricatorUserConfigOptions.php
40–41	You can make this slightly more user friendly by giving the options better labels with `setBoolOptions()`, e.g.: ->setBoolOptions( array( pht('Make real names required'), pht('Make real names optional'), )) This should make the dropdown have more explicit options, instead of "True" / "False".
src/applications/people/controller/PhabricatorPeopleProfileController.php
32–38	Here, I think we have an opportunity to simplify things by just calling: ->setHeader($user->getFullName()) ...and in the two cases below. We could have done this before, but now that the logic is more complicated it's more worthwhile.