Fixes T4728, first pass, Make real name optional on user accounts
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4728: Make real name optional on user accounts
- Commits
- Restricted Diffusion Commit
rPdfcccd4cb882: Add config to require real name, respect config when creating new users, drop…
Default real name config should be false (not required). Create new user, real name should not be required. Toggle config, real name should be required. Users with no real name should be always listed by their usernames.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- checkrealname
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 325 Build 325: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
This looks great -- two small tweaks inline.
| src/applications/people/config/PhabricatorUserConfigOptions.php | ||
|---|---|---|
| 40–41 | You can make this slightly more user friendly by giving the options better labels with setBoolOptions(), e.g.: ->setBoolOptions(
array(
pht('Make real names required'),
pht('Make real names optional'),
))This should make the dropdown have more explicit options, instead of "True" / "False". | |
| src/applications/people/controller/PhabricatorPeopleProfileController.php | ||
| 32–38 | Here, I think we have an opportunity to simplify things by just calling: ->setHeader($user->getFullName()) ...and in the two cases below. We could have done this before, but now that the logic is more complicated it's more worthwhile. | |