Differential D9005
Make workboards truly 'fixed' in display Authored by chad on May 8 2014, 2:57 AM. Tags None Referenced Files
Subscribers Tokens
Details
WIP This sets a shadow fixed to the full screen of the browser for which panels to live in. I have some minor things to fix, but play with it. Specifically I haven't been able to dig up when stuff that overflowwed, doesn't always render even after scroll. Test on a board with many tasks, many panels, small screens. Test on mobile too!
Diff Detail
Event TimelineComment Actions Specifically, I can't figure out why this is happening: This also occurs in differential. I would guess some overflow:hidden is offscreen and thinking it doesn't need to be rendered. But there are so many in ObjItemList that I can't be definitively sure.
Comment Actions So this is where I ended up tonight.
I think this feels pretty good, a nice step up. I'd likely make the individual columns fixed height and scroll like trello, but don't see that as immediately needed. Comment Actions Nice. I think this looks a lot better. I like the removal of the ObjectBox and crumbs a bunch. I think it would still be pretty useful to be able to click back to the project profile from the boards; suggestion on how to get there inline. You're probably aware of this, but I'd say next thing people will want to work better on this is the dragging and dropping as there's some issues with one really tall column and stuff. I think I will get to bang on this javascript a bit as part of T4996 and we'll need to make it work right for dashboards too... I am not sure if the fixed column with vertical sliders bit would make this easier / harder but something to be aware of when tackling either I think. (before epriestley can take a look :P)
Comment Actions Yeah, we should have the ProfileImage, ProjName link back to the page. I don't think the crumbs here were useful, but I could see the consistency argument both ways. I'm not super sold on the no crumbs, so if others feel they are important we can add them. In a follow up diff I will look at making the columns 100% height, with a scrollbar per column (this is more how Trello works). I think that should make some of the UI interactions (moving objects) easier. Though we'd still have to solve being able to drag them off the screen left and right. Comment Actions I'm going to try to get all the columns correct (scrollable) as well here. Seems worth another few hours of tuning. Comment Actions
Comment Actions landing this as is, will tweak more when I don't have the tike. should be a nice improvement as is, worth testing. Comment Actions How are users supposed to reach the column(s) cut at the right of the screen? See https://secure.phabricator.com/project/board/404/ Comment Actions This now works more like Trello, there is a scroll bar at the bottom and users can add unlimited boards. Comment Actions I see, but Trello keeps the horizontal bar always at sight. Now in Phabricator and in a board with enough tasks, you must scroll down t find out that there is a horizontal bar waiting for you.  (Collateral comment: Trello's cards are narrower, which basically makes it more difficult to need that horizontal bar at all. You said somewhere that showing full titles breaks your design, but maybe one day you will want to revisit this decision, following Trello's proven solution. End of collateral comment.) :) Comment Actions @qgil - this diff isn't running on secure.phabricator.com. Generally speaking we don't update secure.phabricator.com after every diff or anything. If you'd like to very functionality on a diff, try arc patch D9005 on your local phabricator instance. Comment Actions The positioning should be fixed to the bottom of the browser in this diff. In my follow up diff, we'll also fix the height of the colums as well so they scroll independently as well. If you update you'll get the newer behavior this diff is trying to correct. Comment Actions Ok, understood. Sometimes it does feel that you push new features to secure.* immediately. :) Comment Actions I think the confusing part is we shipped a hasty version yesterday which is where your instance looks to be at and this diff gets us closer to the intended behavior. I likely won't get it really all working well until the next diff. Comment Actions Yeah I like the horizontal UX here. I need to fix the vertical (long list) UX and I think we're in good shape. I'll file some tasks. | ||||||||||||||||||||||||||||||||||||||||||||||||