Page MenuHomePhabricator
Differential D8975

Use ActionList-based dropdowns in Policy
ClosedPublic
Actions

Authored by epriestley on May 4 2014, 8:55 PM.
Tags
None
Referenced Files
F14026872: D8975.id21320.diff
Fri, Nov 8, 2:51 AM
F13965402: D8975.id.diff
Wed, Oct 16, 1:49 AM
F13957040: D8975.id21293.diff
Mon, Oct 14, 8:06 AM
Unknown Object (File)
Sun, Oct 13, 9:32 PM
Unknown Object (File)
Sun, Oct 13, 6:26 AM
Unknown Object (File)
Sun, Oct 13, 6:26 AM
Unknown Object (File)
Sep 18 2024, 11:11 PM
Unknown Object (File)
Sep 16 2024, 11:09 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPcb4453175170: Use ActionList-based dropdowns in Policy
Summary

See previous diffs. These mostly look reasonable with shared CSS.

Test Plan

Screen_Shot_2014-05-04_at_1.53.23_PM.png (354×314 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21293.May 4 2014, 8:55 PM
epriestley retitled this revision from to Use ActionList-based dropdowns in Policy.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 4 2014, 8:55 PM
Harbormaster completed remote builds in B236: Diff 21293.May 4 2014, 8:56 PM
epriestley updated this revision to Diff 21295.May 4 2014, 9:14 PM
  • Fix icon hover states and sprite construction.
Harbormaster completed remote builds in B238: Diff 21295.May 4 2014, 9:15 PM
chad edited edge metadata.May 4 2014, 9:17 PM

I haven't seen/heard any issues on Font/Icons. Do you want me to swap these out next?

epriestley added a comment.May 4 2014, 9:19 PM

No rush, but these things are probably the highest impact to target next. I can help with the JS versions if they're troublesome.

chad added a comment.May 4 2014, 9:25 PM

it's just css classes, should be simple. just feel bad you're fixing sprites.

btrahan accepted this revision.May 5 2014, 4:49 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 5 2014, 4:49 PM
epriestley closed this revision.May 5 2014, 5:57 PM
epriestley updated this revision to Diff 21320.

Closed by commit rPcb4453175170 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
sprite/
manifest/
14 lines
src/
infrastructure/
celerity/
23 lines
webroot/
rsrc/
css/
layout/
4 lines
14 lines
image/
js/
application/
policy/
36 lines
phuix/
23 lines

Diff 21320

View Options

resources/sprite/manifest/status.json

Loading...
View Options

src/infrastructure/celerity/CeleritySpriteGenerator.php

Loading...
View Options

webroot/rsrc/css/layout/phabricator-action-list-view.css

Loading...
View Options

webroot/rsrc/css/sprite-status.css

Loading...
View Options

webroot/rsrc/image/sprite-status-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-status.png

Loading...
View Options

webroot/rsrc/js/application/policy/behavior-policy-control.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...
Phabricator · Built by Phacility