Check view policy, not join policy, when raising an error for Phame custom domains
ClosedPublic
Actions

Authored by epriestley on May 5 2014, 3:18 PM.

Tags

None

Referenced Files

	F14039108: D8980.id21312.diff
	Mon, Nov 11, 3:46 AM

	F13982158: D8980.id.diff
	Sat, Oct 19, 9:34 PM

	F13967030: D8980.diff
	Wed, Oct 16, 11:08 AM

	F13955032: D8980.id21305.diff
	Sun, Oct 13, 11:54 PM

	F13955031: D8980.id21312.diff
	Sun, Oct 13, 11:53 PM

	F13955030: D8980.id.diff
	Sun, Oct 13, 11:53 PM

	F13954897: D8980.diff
	Oct 13 2024, 11:29 PM

	Unknown Object (File)
	Oct 13 2024, 5:51 PM

View All Files

Subscribers

epriestley

legien

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPac9c82fcdf03: Check view policy, not join policy, when raising an error for Phame custom…

Summary

A user in IRC hit this; this looks like a typo.

Test Plan

Created a new blog with a public view policy, a non-public join policy, and a custom domain.

Diff Detail

Repository

rP Phabricator

Branch

viewpolicy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 247
Build 247: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21305.May 5 2014, 3:18 PM

epriestley retitled this revision from to Check view policy, not join policy, when raising an error for Phame custom domains.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2014, 3:18 PM

legien added a subscriber: legien.May 5 2014, 3:19 PM

Harbormaster completed remote builds in B247: Diff 21305.May 5 2014, 3:20 PM

btrahan accepted this revision.May 5 2014, 4:32 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 5 2014, 4:32 PM

Closed by commit rPac9c82fcdf03 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

blog/

PhameBlogEditController.php

2 lines

Diff 21305

View Options

src/applications/phame/controller/blog/PhameBlogEditController.php

Check view policy, not join policy, when raising an error for Phame custom domainsClosedPublicActions