Page MenuHomePhabricator
Differential D8962

Add piles of special casing to support "mailto:"
ClosedPublic
Actions

Authored by epriestley on May 3 2014, 1:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:11 AM
Unknown Object (File)
Fri, Dec 6, 5:11 AM
Unknown Object (File)
Thu, Dec 5, 5:34 AM
Unknown Object (File)
Nov 27 2024, 11:04 PM
Unknown Object (File)
Nov 20 2024, 10:49 PM
Unknown Object (File)
Nov 15 2024, 5:02 PM
Unknown Object (File)
Nov 11 2024, 10:04 PM
Unknown Object (File)
Nov 8 2024, 6:22 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T3949: Support mailto URI in Remarkup
Commits
rPHU5cfc0c661d44: Add piles of special casing to support "mailto:"
Summary

Ref T3949. Bleh.

Test Plan

Unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
mailto
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/markup/engine/__tests__/remarkup/link-mailto.txt:8TXT3Line Too Long
Warningsrc/markup/engine/__tests__/remarkup/link-mailto.txt:10TXT3Line Too Long
Warningsrc/markup/engine/__tests__/remarkup/link-mailto.txt:12TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 213
Build 213: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21262.May 3 2014, 1:58 AM
epriestley retitled this revision from to Add piles of special casing to support "mailto:".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T3949: Support mailto URI in Remarkup.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 3 2014, 1:58 AM
Harbormaster completed remote builds in B213: Diff 21262.May 3 2014, 1:59 AM
btrahan accepted this revision.May 4 2014, 5:37 PM
btrahan edited edge metadata.

yay unit tests!

This revision is now accepted and ready to land.May 4 2014, 5:37 PM
epriestley closed this revision.May 4 2014, 5:47 PM
epriestley updated this revision to Diff 21283.

Closed by commit rPHU5cfc0c661d44 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
1 line
remarkup/
18 lines
remarkup/
markuprule/
15 lines

Diff 21262

View Options

src/markup/engine/__tests__/PhutilRemarkupEngineTestCase.php

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-mailto.txt

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDocumentLink.php

Loading...
Phabricator · Built by Phacility