Differential D8962

Add piles of special casing to support "mailto:"
ClosedPublic
Actions

Authored by epriestley on May 3 2014, 1:58 AM.

Tags

None

Referenced Files

	F19498720: D8962.id21283.diff
	Thu, Jan 8, 1:16 PM

	F19157357: D8962.id21283.diff
	Dec 13 2025, 1:35 PM

	F19103571: D8962.id.diff
	Dec 5 2025, 11:22 AM

	F19095357: D8962.diff
	Dec 4 2025, 4:59 AM

	F18875398: D8962.diff
	Nov 5 2025, 5:47 PM

	F18856713: D8962.id.diff
	Nov 1 2025, 11:13 AM

	F18851903: D8962.diff
	Oct 31 2025, 5:05 AM

	F18845752: D8962.id21262.diff
	Oct 29 2025, 2:17 PM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T3949: Support mailto URI in Remarkup

Commits

rPHU5cfc0c661d44: Add piles of special casing to support "mailto:"

Summary

Ref T3949. Bleh.

Test Plan

Unit tests.

Diff Detail

Repository

Branch

mailto

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/markup/engine/__tests__/remarkup/link-mailto.txt:8	TXT3	Line Too Long
Warning	src/markup/engine/__tests__/remarkup/link-mailto.txt:10	TXT3	Line Too Long
Warning	src/markup/engine/__tests__/remarkup/link-mailto.txt:12	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 213
Build 213: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21262.May 3 2014, 1:58 AM

epriestley retitled this revision from to Add piles of special casing to support "mailto:".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T3949: Support mailto URI in Remarkup.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 3 2014, 1:58 AM

Harbormaster completed remote builds in B213: Diff 21262.May 3 2014, 1:59 AM

yay unit tests!

This revision is now accepted and ready to land.May 4 2014, 5:37 PM

Closed by commit rPHU5cfc0c661d44 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

PhutilRemarkupEngineTestCase.php

1 line

remarkup/

link-mailto.txt

18 lines

remarkup/

markuprule/

PhutilRemarkupRuleDocumentLink.php

15 lines

Diff 21262

src/markup/engine/tests/PhutilRemarkupEngineTestCase.php

Loading...

src/markup/engine/tests/remarkup/link-mailto.txt

Loading...

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDocumentLink.php

Loading...