Page MenuHomePhabricator
Differential D8943

Allow structured destruction of Differential Revisions
ClosedPublic
Actions

Authored by epriestley on May 2 2014, 12:53 AM.
Tags
None
Referenced Files
F14112289: D8943.id21219.diff
Thu, Nov 28, 12:55 AM
F14112288: D8943.id21214.diff
Thu, Nov 28, 12:54 AM
F14112011: D8943.id.diff
Wed, Nov 27, 11:40 PM
F14111955: D8943.diff
Wed, Nov 27, 11:30 PM
F14108836: D8943.diff
Wed, Nov 27, 12:31 PM
Unknown Object (File)
Sun, Nov 24, 4:53 PM
Unknown Object (File)
Tue, Nov 19, 8:03 AM
Unknown Object (File)
Thu, Oct 31, 4:04 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4749: Implement bin/destroy for monogrammed objects
T4909: Rate limit or restrict access to comment removal
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP889440ead066: Allow structured destruction of Differential Revisions
Summary

Ref T4749. Ref T3265. Ref T4909.

  • Remove old "destroy revision" script.
  • Move to structured bin/remove destruction.
  • Fix some edge issues.
  • Add transaction destruction support.
Test Plan
  • Destroyed a bunch of revisions.
  • Saw diffs, changesets, hunks, transactions, edges, and inlines also get wiped out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21214.May 2 2014, 12:53 AM
epriestley retitled this revision from to Allow structured destruction of Differential Revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: Restricted Maniphest Task, T4909: Rate limit or restrict access to comment removal, T4749: Implement bin/destroy for monogrammed objects.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 2 2014, 12:53 AM
Harbormaster completed remote builds in B184: Diff 21214.May 2 2014, 12:54 AM
btrahan accepted this revision.May 2 2014, 1:06 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 1:06 AM
epriestley closed this revision.May 2 2014, 1:25 AM
epriestley updated this revision to Diff 21219.

Closed by commit rP889440ead066 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
scripts/
differential/
src/
4 lines
applications/
differential/
storage/
45 lines
91 lines
system/
engine/
38 lines
management/
3 lines
transactions/
storage/
32 lines
15 lines

Diff 21219

View Options

scripts/differential/destroy_revision.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/system/engine/PhabricatorDestructionEngine.php

Loading...
View Options

src/applications/system/management/PhabricatorSystemRemoveLogWorkflow.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

Loading...
Phabricator · Built by Phacility