Paths

Table of Contentst

Differential D8943

Allow structured destruction of Differential Revisions
ClosedPublic
Actions

Authored by epriestley on May 2 2014, 12:53 AM.

Tags

None

Referenced Files

	F15410874: D8943.diff
	Wed, Mar 19, 8:37 AM

	F15410048: D8943.diff
	Wed, Mar 19, 6:43 AM

	F15404334: D8943.diff
	Tue, Mar 18, 7:14 AM

	F15393295: D8943.diff
	Sat, Mar 15, 8:47 PM

	F15385212: D8943.id.diff
	Fri, Mar 14, 9:59 PM

	F15381528: D8943.diff
	Fri, Mar 14, 8:06 AM

	F15285092: D8943.diff
	Tue, Mar 4, 11:34 AM

	Unknown Object (File)
	Mon, Feb 24, 9:13 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4749: Implement bin/destroy for monogrammed objects
T4909: Rate limit or restrict access to comment removal
Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP889440ead066: Allow structured destruction of Differential Revisions

Summary

Ref T4749. Ref T3265. Ref T4909.

Remove old "destroy revision" script.
Move to structured bin/remove destruction.
Fix some edge issues.
Add transaction destruction support.

Test Plan

Destroyed a bunch of revisions.
Saw diffs, changesets, hunks, transactions, edges, and inlines also get wiped out.

Diff Detail

Repository

Branch

rm3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/storage/DifferentialRevision.php:474	XHP16	TODO Comment
Advice	src/applications/system/engine/PhabricatorDestructionEngine.php:51	XHP16	TODO Comment
Advice	src/applications/system/engine/PhabricatorDestructionEngine.php:52	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 184
Build 184: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21214.May 2 2014, 12:53 AM

epriestley retitled this revision from to Allow structured destruction of Differential Revisions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: Restricted Maniphest Task, T4909: Rate limit or restrict access to comment removal, T4749: Implement bin/destroy for monogrammed objects.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 2 2014, 12:53 AM

Harbormaster completed remote builds in B184: Diff 21214.May 2 2014, 12:54 AM

btrahan accepted this revision.May 2 2014, 1:06 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 2 2014, 1:06 AM

Closed by commit rP889440ead066 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

differential/

destroy_revision.php

src/

__phutil_library_map__.php

4 lines

applications/

differential/

storage/

DifferentialDiff.php

45 lines

DifferentialRevision.php

91 lines

system/

engine/

PhabricatorDestructionEngine.php

38 lines

management/

PhabricatorSystemRemoveLogWorkflow.php

3 lines

transactions/

storage/

PhabricatorApplicationTransaction.php

32 lines

PhabricatorApplicationTransactionComment.php

15 lines

Diff 21214

scripts/differential/destroy_revision.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/system/engine/PhabricatorDestructionEngine.php

Loading...

src/applications/system/management/PhabricatorSystemRemoveLogWorkflow.php

Loading...

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...

src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

Loading...