Used Cards instead of States for Harbormaster Buildables
ClosedPublic
Actions

Authored by chad on May 1 2014, 9:14 PM.

Tags

None

Referenced Files

	F14020828: D8934.diff
	Wed, Nov 6, 2:59 AM

	F14005175: D8934.id.diff
	Sun, Oct 27, 8:27 AM

	F14004935: D8934.diff
	Sun, Oct 27, 5:42 AM

	F13995006: D8934.id.diff
	Wed, Oct 23, 10:02 AM

	F13971054: D8934.id21198.diff
	Thu, Oct 17, 11:15 AM

	Unknown Object (File)
	Sun, Oct 13, 5:37 PM

	Unknown Object (File)
	Oct 8 2024, 4:38 AM

	Unknown Object (File)
	Sep 12 2024, 9:21 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP173fd49e67d7: Used Cards instead of States for Harbormaster Buildables

Summary

Switched to Obect Cards for better consistency with application search. Added Byline for colorblind/accessability (can move).

Test Plan

Tested my Harbormaster build.

Diff Detail

Repository

rP Phabricator

Branch

hmaster

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 173
Build 173: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21198.May 1 2014, 9:14 PM

chad retitled this revision from to Used Cards instead of States for Harbormaster Buildables.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 1 2014, 9:14 PM

Harbormaster completed remote builds in B173: Diff 21198.May 1 2014, 9:15 PM

epriestley accepted this revision.May 1 2014, 9:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 1 2014, 9:35 PM

Closed by commit rP173fd49e67d7 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildableListController.php

21 lines

Diff 21198

View Options

src/applications/harbormaster/controller/HarbormasterBuildableListController.php

Used Cards instead of States for Harbormaster BuildablesClosedPublicActions