Paths

Table of Contentst

Differential D8924

Minor cleanup of some session code
ClosedPublic
Actions

Authored by epriestley on May 1 2014, 1:35 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4398: Implement two-factor authentication

Commits

Restricted Diffusion Commit
rPa04e138ae247: Minor cleanup of some session code

Summary

Ref T4398. Add some documentation and use phutil_units().

Test Plan

Established a web session.
Established a conduit session.
Entered and exited hisec.
Used "Sessions" panel to examine results.

Diff Detail

Repository

rP Phabricator

Branch

hisec3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 161
Build 161: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21176.May 1 2014, 1:35 PM

epriestley retitled this revision from to Minor cleanup of some session code.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4398: Implement two-factor authentication.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 1 2014, 1:35 PM

Harbormaster completed remote builds in B161: Diff 21176.May 1 2014, 1:36 PM

btrahan accepted this revision.May 1 2014, 5:19 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 1 2014, 5:19 PM

Closed by commit rPa04e138ae247 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

engine/

PhabricatorAuthSessionEngine.php

54 lines

storage/

PhabricatorAuthSession.php

4 lines

Diff 21176

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php