Page MenuHomePhabricator
Differential D8923

Generate QR codes for TOTP tokens
ClosedPublic
Actions

Authored by epriestley on May 1 2014, 4:24 AM.
Tags
None
Referenced Files
F14093891: D8923.diff
Mon, Nov 25, 1:16 PM
Unknown Object (File)
Sun, Nov 24, 12:33 AM
Unknown Object (File)
Sat, Nov 23, 8:09 AM
Unknown Object (File)
Sat, Nov 23, 8:06 AM
Unknown Object (File)
Sat, Nov 23, 8:06 AM
Unknown Object (File)
Sat, Nov 23, 8:06 AM
Unknown Object (File)
Sat, Nov 23, 7:56 AM
Unknown Object (File)
Wed, Nov 13, 6:00 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4398: Implement two-factor authentication
Commits
Restricted Diffusion Commit
rPe14695821758: Generate QR codes for TOTP tokens
Summary

Ref T4398. I found a reasonable-ish LGPLv3 library for doing this, which isn't too huge or unwieldy.

Test Plan
  • Scanned QR code with Authy.
  • Scanned QR code with Google Authenticator.

Screen_Shot_2014-04-30_at_9.22.27_PM.png (1×2 px, 238 KB)

Diff Detail

Repository
rP Phabricator
Branch
hisec2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 158
Build 158: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21173.May 1 2014, 4:24 AM
epriestley retitled this revision from to Generate QR codes for TOTP tokens.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4398: Implement two-factor authentication.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 1 2014, 4:24 AM
epriestley updated this revision to Diff 21174.May 1 2014, 4:25 AM
  • Remove random +x on qrcode files.
Harbormaster completed remote builds in B158: Diff 21173.May 1 2014, 4:25 AM
Harbormaster completed remote builds in B159: Diff 21174.
epriestley updated this revision to Diff 21175.May 1 2014, 4:28 AM
  • Make the QR code pixels square in Chrome.
Harbormaster completed remote builds in B160: Diff 21175.May 1 2014, 4:29 AM
btrahan accepted this revision.May 1 2014, 5:16 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/auth/factor/PhabricatorAuthFactorTOTP.php
275

Well, now I have seen one of those QR things drawn in PHP.

This revision is now accepted and ready to land.May 1 2014, 5:16 PM
epriestley closed this revision.May 1 2014, 5:23 PM
epriestley updated this revision to Diff 21190.

Closed by commit rPe14695821758 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
externals/
phpqrcode/
165 lines
45 lines
2 lines
3312 lines
src/
applications/
auth/
factor/
61 lines

Diff 21173

View Options

externals/phpqrcode/LICENSE

Loading...
View Options

externals/phpqrcode/README

Loading...
View Options

externals/phpqrcode/VERSION

Loading...
View Options

externals/phpqrcode/phpqrcode.php

Loading...
View Options

src/applications/auth/factor/PhabricatorAuthFactorTOTP.php

Loading...
Phabricator · Built by Phacility