Require the "ctype" extension explicitly
ClosedPublic
Actions

Authored by epriestley on Apr 29 2014, 5:18 PM.

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T4916: Add setup test for ctype "extension" because it's off by default in OpenSUSE

Commits

Restricted Diffusion Commit
rP301c7d0a1467: Require the "ctype" extension explicitly

Summary

Fixes T4916. Although every normal build of PHP has this in the core, at least one distribution which users could reasonably encounter does not.

Test Plan

Changed string to "ctypex", got setup warning. Changed to "ctype", got no warning.

Diff Detail

Repository

rP Phabricator

Branch

ctype1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 120
Build 120: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21108.Apr 29 2014, 5:18 PM

epriestley retitled this revision from to Require the "ctype" extension explicitly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, hach-que.

epriestley added a task: T4916: Add setup test for ctype "extension" because it's off by default in OpenSUSE.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 29 2014, 5:18 PM

Harbormaster completed remote builds in B120: Diff 21108.Apr 29 2014, 5:19 PM

btrahan accepted this revision.Apr 29 2014, 5:30 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 29 2014, 5:30 PM

Closed by commit rP301c7d0a1467 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorSetupCheckExtensions.php

1 line

Diff 21108

View Options

src/applications/config/check/PhabricatorSetupCheckExtensions.php

Require the "ctype" extension explicitlyClosedPublicActions