Fixes T2576. Also hyperlinks "Notifications" and "Messages" for easier quick navigation to those areas. Maybe we could get rid of the "See All X" UI at the bottom and use these links?
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rPbcdef099c243: Notifications - add a "Clear All Notifications" link to dropdown
cleared all notifications from new UI - it worked! observed new linked "Notifications" and "Messages" headers
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T2576
- Lint
Lint Errors Severity Location Code Message Error /Users/btrahan/Dropbox/code/libphutil/src/future/http/HTTPSFuture.php:535 PHL1 Unknown Symbol - Unit
No Test Coverage - Build Status
Buildable 117 Build 117: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Clearing the cache should be:
- Update arcanist/
- Remove libphutil/src/.phutil_module_src
Comment Actions
Clear all should be up floated right next to "Notifications". It's pretty cumbersome to scroll down constantly just to clear them, keep the action near the mouse.
Comment Actions
put it in the header
what other style fixes should happen there?
also, any thoughts on whether linking the header is 1) a good idea and 2) if good, worth deprecating the "View All X" in the footer?
Comment Actions
My guess is you (like me) are getting tired of looking at notifications for Harbormaster builds. I also tire of CC notifications on tasks I'm not. It's not a huge deal and this likely solves 80% of my concerns. The two scenarios are:
- I just want to see what's new and one-click clear them.
- I want to scroll and read everything.
So optimizing the clear at the top and read all at the bottom seems to make sense to me. Only other thing I'd maybe do is increase the hit-area of the Clear All action.
Comment Actions
I liked the clickable header because for me I often have N notifications where after I read the first few all N are now off screen. Its nice to quick click for me to see all. Not attached to it.
