A number of interfaces could use a more consice looking ObjectItemList for showing pass/fail/warn states.
- Added a new "State" for PHUIObjectItemListView
- Updated UIExamples
- Implemented in Herald (next Harmormaster)
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rPcafd2dd6cb4e: Add Success/Fail states to PHUIObjectList
UIExamples / Herald, desktop and mobile
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- success-objects
- Lint
Lint Warnings Severity Location Code Message Warning webroot/rsrc/css/phui/phui-object-item-list-view.css:623 TXT3 Line Too Long - Unit
Tests Passed - Build Status
Buildable 115 Build 115: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Harbormaster brought me here. =D
| src/view/phui/PHUIObjectItemListView.php | ||
|---|---|---|
| 66 | if $states should always be an array, its worth typehinting array setStates(array $states) and then PHP will error if $states is some non-array value. This is also nice documentation. Note if $states should be null sometimes you could do setStates(array $states = null) ...there's also assert_instances_of($states, 'classStatesShouldBe') if you really want to be hardcore here. | |