Page MenuHomePhabricator
Differential D8886

Make two-factor auth actually work
ClosedPublic
Actions

Authored by epriestley on Apr 28 2014, 5:03 PM.
Tags
None
Referenced Files
F19188055: D8886.id21080.diff
Dec 16 2025, 7:10 AM
F19181299: D8886.id21080.diff
Dec 16 2025, 2:45 AM
F19152096: D8886.diff
Dec 11 2025, 12:38 AM
F19152019: D8886.diff
Dec 11 2025, 12:13 AM
F19074372: D8886.id21080.diff
Dec 1 2025, 5:03 AM
F19073894: D8886.id21081.diff
Dec 1 2025, 3:27 AM
F19073097: D8886.diff
Dec 1 2025, 12:44 AM
F19051253: D8886.id21080.diff
Nov 28 2025, 12:13 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4398: Implement two-factor authentication
Commits
Restricted Diffusion Commit
rPa017a8e02b51: Make two-factor auth actually work
Summary

Ref T4398. Allows auth factors to render and validate when prompted to take a hi-sec action.

This has a whole lot of rough edges still (see D8875) but does fundamentally work correctly.

Test Plan
  • Added two different TOTP factors to my account for EXTRA SECURITY.
  • Took hisec actions with no auth factors, and with attached auth factors.
  • Hit all the error/failure states of the hisec entry process.
  • Verified hisec failures appear in activity logs.

Diff Detail

Repository
rP Phabricator
Branch
hisec5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 102
Build 102: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21080.Apr 28 2014, 5:03 PM
epriestley retitled this revision from to Make two-factor auth actually work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4398: Implement two-factor authentication.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 28 2014, 5:03 PM
epriestley added a comment.Apr 28 2014, 5:03 PM

My account is secure to the max!!

Screen_Shot_2014-04-28_at_9.58.49_AM.png (1×1 px, 179 KB)

Harbormaster completed remote builds in B102: Diff 21080.Apr 28 2014, 5:04 PM
btrahan accepted this revision.Apr 28 2014, 5:14 PM
btrahan edited edge metadata.

Macro epriestleyweddingcake: false topper lyuba at comp too

This revision is now accepted and ready to land.Apr 28 2014, 5:14 PM
epriestley added a comment.Apr 28 2014, 5:18 PM

topper.jpg (598×800 px, 403 KB)

epriestley closed this revision.Apr 28 2014, 5:20 PM
epriestley updated this revision to Diff 21081.

Closed by commit rPa017a8e02b51 (authored by @epriestley).

Revision Contents
Changeset List

Diff 21080

View Options

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...
View Options

src/applications/auth/exception/PhabricatorAuthHighSecurityRequiredException.php

Loading...
View Options

src/applications/auth/factor/PhabricatorAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorAuthFactorTOTP.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthFactorConfig.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserLog.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelMultiFactor.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

Loading...
Phabricator · Built by Phacility