Fix wording of "differential.sticky-accept"
ClosedPublic
Actions

Authored by epriestley on Apr 28 2014, 4:26 PM.

Tags

None

Referenced Files

	F13806961: D8884.diff
	Mon, Sep 16, 10:31 AM

	F13804034: D8884.diff
	Sun, Sep 15, 4:24 PM

	Unknown Object (File)
	Sun, Sep 8, 4:12 PM

	Unknown Object (File)
	Wed, Aug 28, 4:58 PM

	Unknown Object (File)
	Wed, Aug 28, 1:45 PM

	Unknown Object (File)
	Mon, Aug 26, 1:06 AM

	Unknown Object (File)
	Sun, Aug 25, 1:13 AM

	Unknown Object (File)
	Fri, Aug 23, 3:31 PM

View All Files

Subscribers

epriestley

qgil

Tokens

"Like" token, awarded by qgil.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPbf6bda6ef481: Fix wording of "differential.sticky-accept"

Summary

See http://fab.wmflabs.org/T226. The summary for this option is confusing, because "true" means sticky but the wording implies "true" means non-sticky.

Test Plan

Looked at the option in summary view.
Reviewed related text, none of the other copy here seems confusing or ambiugous to me.

Diff Detail

Repository

rP Phabricator

Branch

hword1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 99
Build 99: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21073.Apr 28 2014, 4:26 PM

epriestley retitled this revision from to Fix wording of "differential.sticky-accept".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a subscriber: qgil.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 28 2014, 4:26 PM

Harbormaster completed remote builds in B99: Diff 21073.Apr 28 2014, 4:27 PM

chad accepted this revision.Apr 28 2014, 4:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 28 2014, 4:27 PM

Closed by commit rPbf6bda6ef481 (authored by @epriestley).

qgil awarded a token.Apr 28 2014, 4:38 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

config/

PhabricatorDifferentialConfigOptions.php

2 lines

Diff 21073

View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Fix wording of "differential.sticky-accept"ClosedPublicActions