Page MenuHomePhabricator

Clarify STRICT_ALL_TABLES instructions
ClosedPublic

Authored by epriestley on Apr 23 2014, 7:38 PM.
Tags
None
Referenced Files
F14053580: D8847.diff
Fri, Nov 15, 5:03 PM
F14041969: D8847.diff
Mon, Nov 11, 11:16 PM
F14025399: D8847.diff
Thu, Nov 7, 5:17 PM
F14005741: D8847.diff
Sun, Oct 27, 6:45 PM
F14005156: D8847.diff
Sun, Oct 27, 8:06 AM
F13978582: D8847.id20987.diff
Oct 18 2024, 11:56 PM
F13966876: D8847.id20989.diff
Oct 16 2024, 10:14 AM
Unknown Object (File)
Oct 13 2024, 9:57 PM

Details

Reviewers
btrahan
csilvers
Commits
Restricted Diffusion Commit
rP67f015a76c79: Clarify STRICT_ALL_TABLES instructions
Summary
  • Mention the [mysqld] section.
  • Should be sql_mode, not sql-mode.
  • Improve clarity of the text.
  • Slightly nicer markup.
Test Plan

Screen_Shot_2014-04-23_at_12.37.46_PM.png (1×1 px, 153 KB)

Diff Detail

Repository
rP Phabricator
Branch
mysqld
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51
Build 51: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Clarify STRICT_ALL_TABLES instructions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, csilvers.
  • Give sql_mode nice formatting too.
btrahan edited edge metadata.

Bug report - if you click the "harbormaster build" notification, you go to harbormaster as expected, but the notification count doesn't decrement and the notification doesn't clear.

This revision is now accepted and ready to land.Apr 23 2014, 7:44 PM

Thanks! FWIW, I haven't gotten this to work yet (though I was editing a different config file than my.cnf, so I don't yet assume that the instructions here are still problematic).

One question I still have: is it necessary to restart mysqld after making this chagne? I assume so, but you may want to mention that explicitly.

epriestley edited edge metadata.
  • Mention restarting.

I'll hold this until you actually get it working in case these turn out to be the worst instructions ever written or whatever.

OK, following the instructions works. It looks like the problem was with permissions on my new .cnf file. (They were too generous? I can't find an error message, sigh. I'm rambling.)

epriestley updated this revision to Diff 20990.

Closed by commit rP67f015a76c79 (authored by @epriestley).

(Turns out it was an apparmor issue. Aaargh!)