Paths

Table of Contentst

Censor URIs in service profile log
ClosedPublic
Actions

Authored by epriestley on Apr 21 2014, 9:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 31, 11:48 AM

	Unknown Object (File)
	Tue, Jan 28, 4:35 PM

	Unknown Object (File)
	Tue, Jan 28, 3:32 AM

	Unknown Object (File)
	Sun, Jan 26, 9:10 PM

	Unknown Object (File)
	Fri, Jan 24, 4:47 AM

	Unknown Object (File)
	Fri, Jan 17, 7:50 PM

	Unknown Object (File)
	Tue, Jan 14, 11:29 AM

	Unknown Object (File)
	Tue, Jan 14, 10:24 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

rPHU0199100a9b6d: Censor URIs in service profile log

Summary

Mailgun requests can hit a credentialed URI. Censor credentials from --trace URIs.

Test Plan

Ran bin/mail send-test ... --trace and saw censored credentials.

Diff Detail

Repository

rPHU libphutil

Branch

censorp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35
Build 35: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20956.Apr 21 2014, 9:43 PM

epriestley retitled this revision from to Censor URIs in service profile log.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2014, 9:43 PM

Harbormaster completed remote builds in B35: Diff 20956.Apr 21 2014, 9:44 PM

btrahan accepted this revision.Apr 21 2014, 10:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 21 2014, 10:40 PM

Closed by commit rPHU0199100a9b6d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

serviceprofiler/

PhutilServiceProfiler.php

2 lines

Diff 20956

View Options

src/serviceprofiler/PhutilServiceProfiler.php

Censor URIs in service profile logClosedPublicActions