Page MenuHomePhabricator

Censor URIs in service profile log
ClosedPublic

Authored by epriestley on Apr 21 2014, 9:43 PM.
Tags
None
Referenced Files
F14034836: D8833.id20956.diff
Sun, Nov 10, 2:22 AM
F14034759: D8833.id20963.diff
Sun, Nov 10, 2:04 AM
F14033327: D8833.diff
Sat, Nov 9, 5:28 PM
F13995761: D8833.id20963.diff
Wed, Oct 23, 3:17 PM
F13985268: D8833.diff
Sun, Oct 20, 7:16 PM
F13979550: D8833.id.diff
Sat, Oct 19, 5:08 AM
F13965446: D8833.id20956.diff
Wed, Oct 16, 2:10 AM
F13955209: D8833.diff
Oct 14 2024, 12:30 AM
Subscribers

Details

Summary

Mailgun requests can hit a credentialed URI. Censor credentials from --trace URIs.

Test Plan

Ran bin/mail send-test ... --trace and saw censored credentials.

Diff Detail

Repository
rPHU libphutil
Branch
censorp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35
Build 35: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Censor URIs in service profile log.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2014, 10:40 PM
epriestley updated this revision to Diff 20963.

Closed by commit rPHU0199100a9b6d (authored by @epriestley).