@zeeg wants this for some build stuff and we'd like it in general to make Mailgun work better. It's a bit messy because of how cURL works. See pages of comments inline.
Details
Details
- Reviewers
btrahan - Commits
- rPHU159b5065d9d4: Support file attachments on HTTPSFuture
- Added tests for the parser stuff.
- Made various requests with and without file attachments and saw them encode data as expected.
- Made some dangerous requests (with "@") and saw them fail.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- attachfile
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 32 Build 32: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
We don't formally support PHP before 5.2.3, but we don't have a hard kill for earlier versions in libphutil (we do in Phabricator).
I think the major risk here is someone including the library, or copy/pasting the code, or using it as a reference to implement something similar. In most cases, if you do that and run on an old PHP you get a nonfunctional feature which is broken in an obvious way (e.g., missing function or something like that), but in this case you'd get a gaping security hole. The two lines of cruft feel kind-of-okayish to me given the extreme badness of not doing the check.