Page MenuHomePhabricator

Remove loadReleephBranch and loadReleephProject from ReleephRequest
ClosedPublic

Authored by epriestley on Apr 19 2014, 5:18 PM.
Tags
None
Referenced Files
F14003962: D8820.id20929.diff
Sat, Oct 26, 1:25 PM
F14003961: D8820.id20938.diff
Sat, Oct 26, 1:25 PM
F13986077: D8820.id20929.diff
Mon, Oct 21, 12:26 AM
F13982649: D8820.id20929.diff
Oct 20 2024, 12:54 AM
F13982640: D8820.id.diff
Oct 20 2024, 12:49 AM
F13982636: D8820.id20938.diff
Oct 20 2024, 12:48 AM
F13978147: D8820.diff
Oct 18 2024, 9:50 PM
F13974934: D8820.id.diff
Oct 18 2024, 7:59 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPd75d0acba517: Remove loadReleephBranch and loadReleephProject from ReleephRequest
Summary

Ref T3551. Ref T3549. Mostly unnecessary with modern calls.

Test Plan
  • Called releeph.queryrequests.
  • Called releeph.request.
  • Called releephwork.getbranchcommitmessage.
  • Called releephwork.getcommitmessage.
  • Called releephwork.nextrequest.
  • Viewed and edited branches and requests.
  • Made a comment on a request.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove loadReleephBranch and loadReleephProject from ReleephRequest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: Restricted Maniphest Task, Restricted Maniphest Task.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2014, 4:42 PM
epriestley updated this revision to Diff 20938.

Closed by commit rPd75d0acba517 (authored by @epriestley).