Paths

Table of Contentst

Differential D8802

Implement PhabricatorApplicationTransactionInterface in Differential
ClosedPublic
Actions

Authored by epriestley on Apr 17 2014, 6:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 8:24 PM

	Unknown Object (File)
	Sun, Dec 22, 8:24 PM

	Unknown Object (File)
	Sun, Dec 22, 8:24 PM

	Unknown Object (File)
	Sun, Dec 22, 8:24 PM

	Unknown Object (File)
	Fri, Dec 13, 8:33 AM

	Unknown Object (File)
	Thu, Dec 12, 12:47 AM

	Unknown Object (File)
	Sat, Dec 7, 8:41 PM

	Unknown Object (File)
	Fri, Nov 29, 1:55 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T1049: Implement Harbormaster
T4810: When builds finish, post a transaction to the buildable

Commits

Restricted Diffusion Commit
rP49bc32f12d82: Implement PhabricatorApplicationTransactionInterface in Differential

Summary

Ref T4810. Ultimate goal is to let Harbormaster post a "build passed/failed" transaction. To prepare for that, implement PhabricatorApplicationTransactionInterface in Differential.

To allow Harbormaster to take action on diffs but have the transactions apply to revisions, I added a new method so that objects can redirect transactions to some other object.

Test Plan

Subscribed/unsubscribed/attached/detached from Differential, saw transactions appear properly.

Diff Detail

Repository

Branch

hm6

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20883.Apr 17 2014, 6:17 PM

epriestley retitled this revision from to Implement PhabricatorApplicationTransactionInterface in Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4810: When builds finish, post a transaction to the buildable.

Herald added a subscriber: epriestley.Apr 17 2014, 6:17 PM

btrahan accepted this revision.Apr 17 2014, 6:38 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2014, 6:38 PM

Closed by commit rP49bc32f12d82 (authored by @epriestley).

epriestley mentioned this in D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.Dec 20 2018, 6:43 PM

epriestley mentioned this in rP11cf8f05b176: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.Dec 20 2018, 11:16 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

storage/

DifferentialDiff.php

29 lines

DifferentialRevision.php

19 lines

legalpad/

storage/

LegalpadDocument.php

5 lines

macro/

storage/

PhabricatorFileImageMacro.php

4 lines

pholio/

storage/

4 lines

search/

controller/

PhabricatorSearchAttachController.php

6 lines

subscriptions/

controller/

PhabricatorSubscriptionsEditController.php

6 lines

transactions/

interface/

PhabricatorApplicationTransactionInterface.php

30 lines

Diff 20883

src/__phutil_library_map__.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/legalpad/storage/LegalpadDocument.php

Loading...

src/applications/macro/storage/PhabricatorFileImageMacro.php

Loading...

src/applications/pholio/storage/PholioMock.php

Loading...

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

Loading...

src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php

Loading...