Page MenuHomePhabricator
Differential D8777

Maniphest - remove "attach file" action
ClosedPublic
Actions

Authored by btrahan on Apr 15 2014, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 11:57 PM
Unknown Object (File)
Fri, Jan 17, 8:46 PM
Unknown Object (File)
Fri, Jan 17, 4:17 PM
Unknown Object (File)
Tue, Dec 31, 6:58 AM
Unknown Object (File)
Fri, Dec 27, 2:53 PM
Unknown Object (File)
Dec 12 2024, 4:59 PM
Unknown Object (File)
Dec 11 2024, 2:50 PM
Unknown Object (File)
Dec 8 2024, 10:12 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4655: Upload Files action doesn't work
Commits
Restricted Diffusion Commit
rPc845b757ee3a: Maniphest - remove "attach file" action
Summary

Fixes T4655. Basically leaves the display code intact for legacy installs but removes the option from the UI and removes "create" code.

Test Plan

tried to attach file and the action was not in the dropdown!
made a new task and it worked!
commented on an old task and it worked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan updated this revision to Diff 20830.Apr 15 2014, 5:27 PM
btrahan added a task: T4655: Upload Files action doesn't work.
btrahan retitled this revision from to Maniphest - remove "attach file" action.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley.Apr 15 2014, 5:27 PM
epriestley requested changes to this revision.Apr 15 2014, 5:30 PM
epriestley edited edge metadata.

Looks good, but let's get rid of the code to write these transactions too -- I think there's a decent chunk of it in ManiphestTransactionSaveController.

This revision now requires changes to proceed.Apr 15 2014, 5:30 PM
epriestley added a comment.Apr 15 2014, 5:30 PM

I think some stuff in ConduitAPI_maniphest_Method can probably die, too

btrahan updated this revision to Diff 20831.Apr 15 2014, 5:37 PM
btrahan edited edge metadata.

nuke more code

btrahan updated this object.Apr 15 2014, 5:38 PM
btrahan edited the test plan for this revision. (Show Details)
btrahan edited edge metadata.
epriestley accepted this revision.Apr 15 2014, 5:39 PM
epriestley edited edge metadata.

oh yeahhh

This revision is now accepted and ready to land.Apr 15 2014, 5:39 PM
btrahan closed this revision.Apr 15 2014, 5:49 PM
btrahan updated this revision to Diff 20832.

Closed by commit rPc845b757ee3a (authored by @btrahan).

Revision Contents
Changeset List

Diff 20832

View Options

src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
Phabricator · Built by Phacility