...add a "renderingTarget" to FeedStory and use it as appropos. Overall, not a ton of changes was necessary to make this work. I think this could be made to be even cleaner by going through each and every feed story and re-implementing as necessary with the full toolset available. But this is good enough for now I think, and just something to keep cleaning up when we're in here. Fixes T4630.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4630: Render feed to text properly and add human-readable text to Feed hooks
- Commits
- Restricted Diffusion Commit
rP3e0b3a1db5db: Feed - fix some whacky "text mode" rendering code
made a task. gave it a token. viewed my feed - saw stories. used conduit.feed.query with mode == 'text' and got good readable results.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/maniphest/controller/ManiphestTransactionSaveController.php | ||
|---|---|---|
| 152–159 | this is a bonus bug fix; the break thing won't work anymore now that this code isn't in a switch | |