Disable rate limiting by default in general
ClosedPublic
Actions

Authored by epriestley on Apr 9 2014, 6:46 PM.

Details

Reviewers

btrahan
sophiebits

Commits

Restricted Diffusion Commit
rPc887871d30b7: Disable rate limiting by default in general

Summary

This is still too rough to enable by default. We can turn it on for secure.phabricator.com and tweak it a bit first, and then release it in general with higher defaults and more sensible behavior in edge cases.

Test Plan

Loaded some pages.

Diff Detail

Repository

rP Phabricator

Branch

noratelimit

Lint

Lint Errors

Severity	Location	Code	Message
Error	support/PhabricatorStartup.php:317	XHP31	Use Of PHP 5.3 Features
Advice	support/PhabricatorStartup.php:45	XHP16	TODO Comment

Unit

No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20718.Apr 9 2014, 6:46 PM

epriestley retitled this revision from to Disable rate limiting by default in general.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: sophiebits, btrahan.

Herald added a subscriber: epriestley.Apr 9 2014, 6:46 PM

sophiebits accepted this revision.Apr 9 2014, 6:48 PM

sophiebits edited edge metadata.

This revision is now accepted and ready to land.Apr 9 2014, 6:48 PM

Closed by commit rPc887871d30b7 (authored by @epriestley).

epriestley mentioned this in T12612: Design (and possibly implement) production rate limiting controls.Apr 21 2017, 2:02 PM

Revision Contents
Changeset List

Path

Size

support/

PhabricatorStartup.php

6 lines

Diff 20718

View Options

support/PhabricatorStartup.php

Disable rate limiting by default in generalClosedPublicActions