Page MenuHomePhabricator

Use correct viewer for debug.stop-on-redirect
ClosedPublic

Authored by epriestley on Apr 8 2014, 12:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 6:59 AM
Unknown Object (File)
Sun, Feb 23, 10:23 PM
Unknown Object (File)
Sun, Feb 9, 12:12 PM
Unknown Object (File)
Sun, Feb 9, 12:12 PM
Unknown Object (File)
Sun, Feb 9, 12:12 PM
Unknown Object (File)
Sun, Feb 9, 12:12 PM
Unknown Object (File)
Jan 29 2025, 9:18 AM
Unknown Object (File)
Jan 28 2025, 6:43 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP58ba8e7d6359: Use correct viewer for debug.stop-on-redirect
Summary

See https://github.com/facebook/phabricator/pull/563.

I think this secondary construction of a $user is very old, and predates subsequent changes which cause a proper user to construct earlier, so using the user on the $request should (I think) always work. I couldn't immediately find any cases where it does not.

Test Plan

With debug.stop-on-redirect set, hit various redirects, like jump-naving to T1. Got a proper stop dialog.

Diff Detail

Repository
rP Phabricator
Branch
redir
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Use correct viewer for debug.stop-on-redirect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2014, 5:20 PM
epriestley updated this revision to Diff 20680.

Closed by commit rP58ba8e7d6359 (authored by @epriestley).