Page MenuHomePhabricator

Include storyText in feed POST data
ClosedPublic

Authored by sophiebits on Apr 5 2014, 5:52 AM.
Tags
None
Referenced Files
F14390216: D8710.id20660.diff
Sat, Dec 21, 6:15 PM
Unknown Object (File)
Sat, Dec 7, 3:05 AM
Unknown Object (File)
Wed, Dec 4, 5:21 AM
Unknown Object (File)
Tue, Nov 26, 1:04 PM
Unknown Object (File)
Tue, Nov 26, 12:38 PM
Unknown Object (File)
Mon, Nov 25, 8:33 AM
Unknown Object (File)
Nov 13 2024, 4:53 AM
Unknown Object (File)
Nov 3 2024, 3:37 PM
Subscribers

Details

Summary

I also changed PhabricatorApplicationTransactionFeedStory and the TokenGivenFeedStory to include only the title/first line of the feed story, which is more convenient (previously, strip_tags gave a multi-line story without even any linebreaks) and more consistent with the other story types.

Test Plan

Added a requestbin URL to feed.http-hooks, commented on a Differential, and saw storyText equal to "alpert added a comment to D2: c." in the POST data it received.

Diff Detail

Repository
rP Phabricator
Branch
feed-hook-title
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

sophiebits retitled this revision from to Include storyText in feed POST data.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 6 2014, 6:48 PM
epriestley updated this revision to Diff 20660.

Closed by commit rPcd829434d49d (authored by @spicyj, committed by @epriestley).