Page MenuHomePhabricator
Differential D8684

Make errors in dialogs look reasonable instead of hideous
ClosedPublic
Actions

Authored by epriestley on Apr 3 2014, 12:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 2:48 PM
Unknown Object (File)
Dec 13 2024, 1:20 PM
Unknown Object (File)
Dec 13 2024, 12:57 AM
Unknown Object (File)
Dec 7 2024, 10:36 AM
Unknown Object (File)
Dec 5 2024, 4:45 AM
Unknown Object (File)
Nov 29 2024, 2:47 PM
Unknown Object (File)
Nov 27 2024, 10:17 AM
Unknown Object (File)
Nov 26 2024, 6:00 AM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPc9311a9eaeba: Make errors in dialogs look reasonable instead of hideous
Summary

I accidentally made these exceptionally ugly recently.

Test Plan

Screen_Shot_2014-04-02_at_5.26.30_PM.png (670×992 px, 89 KB)

Diff Detail

Repository
rP Phabricator
Branch
errmail1x
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Diff 20591.Apr 3 2014, 12:31 AM
epriestley retitled this revision from to Make errors in dialogs look reasonable instead of hideous.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
Herald added subscribers: chad, epriestley.Apr 3 2014, 12:31 AM
chad edited edge metadata.Apr 3 2014, 1:38 AM

pls add img k thx

ohunhappy.png (71×84 px, 4 KB)

chad accepted this revision.Apr 3 2014, 1:39 AM
chad edited edge metadata.

oh i meant img for exception dialogs nm

This revision is now accepted and ready to land.Apr 3 2014, 1:39 AM
epriestley closed this revision.Apr 3 2014, 6:23 PM
epriestley updated this revision to Diff 20612.

Closed by commit rPc9311a9eaeba (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
aphront/
configuration/
5 lines
applications/
conpherence/
controller/
2 lines
system/
engine/
13 lines
view/
12 lines
form/
20 lines
webroot/
rsrc/
css/
aphront/
21 lines

Diff 20591

View Options

resources/celerity/map.php

Loading...
View Options

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/system/engine/PhabricatorSystemActionEngine.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

src/view/form/AphrontErrorView.php

Loading...
View Options

webroot/rsrc/css/aphront/error-view.css

Loading...
Phabricator · Built by Phacility