Herald - print out rule monogram rather than rule phid on transcript controller
ClosedPublic
Actions

Authored by btrahan on Apr 2 2014, 6:55 PM.

Details

Reviewers

Maniphest Tasks

T4632: Display Herald rule name instead of PHID in Test Console

Commits

Restricted Diffusion Commit
rPb50426a98fc0: Herald - print out rule monogram rather than rule phid on transcript controller

Summary

Fixes T4632.

Test Plan

viewed a transcript for rule x which depends on rule y and noted "rule y" printed out rather than "PHID-BLAH-BLAH"

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 20572.Apr 2 2014, 6:55 PM

btrahan added a task: T4632: Display Herald rule name instead of PHID in Test Console.

btrahan retitled this revision from to Herald - print out rule name rather than rule phid on transcript controller.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley.Apr 2 2014, 6:55 PM

Screen_Shot_2014-04-02_at_11.56.24_AM.png (1×2 px, 576 KB)

btrahan retitled this revision from Herald - print out rule name rather than rule phid on transcript controller to Herald - print out rule monogram rather than rule phid on transcript controller.Apr 2 2014, 6:57 PM

epriestley accepted this revision.Apr 2 2014, 6:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 2 2014, 6:59 PM

Closed by commit rPb50426a98fc0 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldTranscriptController.php

35 lines

Diff 20573

View Options

src/applications/herald/controller/HeraldTranscriptController.php

Herald - print out rule monogram rather than rule phid on transcript controllerClosedPublicActions