Page MenuHomePhabricator

Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator
ClosedPublic

Authored by epriestley on Mar 31 2014, 7:45 PM.
Tags
None
Referenced Files
F19719456: D8658.id20530.diff
Thu, Feb 12, 5:50 PM
F19646789: D8658.diff
Feb 6 2026, 2:10 AM
F19307402: D8658.diff
Dec 24 2025, 6:54 PM
F19081858: D8658.id.diff
Dec 2 2025, 8:38 AM
F19065912: D8658.diff
Nov 30 2025, 3:23 AM
F18855368: D8658.id.diff
Nov 1 2025, 5:02 AM
F18848130: D8658.diff
Oct 30 2025, 3:31 AM
F18786708: D8658.id20541.diff
Oct 14 2025, 8:04 PM
Subscribers

Details

Summary

Fixes T4649. The issue in that task is caused because we're submitting a block of text including comments. We've probably been doing this for a long time, but maybe were more liberal in parsing before. Instead, strip them.

Test Plan

Ran arc diff --verbatim and got "Dxxx" prefilled correctly.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2014, 9:43 PM
epriestley updated this revision to Diff 20541.

Closed by commit rARC5280f3708ef7 (authored by @epriestley).