Page MenuHomePhabricator

Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator
ClosedPublic

Authored by epriestley on Mar 31 2014, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 12:45 AM
Unknown Object (File)
Sat, Nov 16, 3:48 PM
Unknown Object (File)
Mon, Nov 11, 9:24 PM
Unknown Object (File)
Thu, Nov 7, 9:38 PM
Unknown Object (File)
Oct 22 2024, 2:44 AM
Unknown Object (File)
Oct 1 2024, 11:10 AM
Unknown Object (File)
Sep 12 2024, 9:20 AM
Unknown Object (File)
Sep 12 2024, 9:20 AM
Subscribers

Details

Summary

Fixes T4649. The issue in that task is caused because we're submitting a block of text including comments. We've probably been doing this for a long time, but maybe were more liberal in parsing before. Instead, strip them.

Test Plan

Ran arc diff --verbatim and got "Dxxx" prefilled correctly.

Diff Detail

Repository
rARC Arcanist
Branch
verbatimid
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley retitled this revision from to Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2014, 9:43 PM
epriestley updated this revision to Diff 20541.

Closed by commit rARC5280f3708ef7 (authored by @epriestley).