Add pager to all Audit Views
ClosedPublic
Actions

Authored by chad on Mar 29 2014, 3:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 1:23 AM

	Unknown Object (File)
	Sat, Dec 7, 3:01 PM

	Unknown Object (File)
	Sat, Nov 30, 1:07 PM

	Unknown Object (File)
	Nov 14 2024, 1:47 PM

	Unknown Object (File)
	Nov 8 2024, 1:37 PM

	Unknown Object (File)
	Nov 7 2024, 2:37 PM

	Unknown Object (File)
	Nov 7 2024, 2:11 PM

	Unknown Object (File)
	Nov 7 2024, 1:20 PM

Subscribers

Details

Reviewers

epriestley

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPcc626b030632: Add pager to all Audit Views

Summary

Fixes T1153, removes the "active" restriction from pagination

Test Plan

Bring up audit, test pager exists, and doesn't exist when needed

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 20489.Mar 29 2014, 3:36 PM

chad retitled this revision from to Add pager to all Audit Views.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: Restricted Maniphest Task.

Herald added subscribers: Korvin, epriestley.Mar 29 2014, 3:36 PM

Looks good to me. So now whatever audit list I see will be paginated.

This UI is a mess for like 30 other reasons, but this clearly seems like an improvement. Thanks!

This revision is now accepted and ready to land.Mar 29 2014, 3:41 PM

Closed by commit rPcc626b030632 (authored by @chad).

Maybe the default 100 per page setting needs to be configured somehow. For me 100 records on a page is too much.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

controller/

PhabricatorAuditListController.php

45 lines

Diff 20490

View Options

src/applications/audit/controller/PhabricatorAuditListController.php

Add pager to all Audit ViewsClosedPublicActions