Page MenuHomePhabricator

Fix maniphest "create" transactions
ClosedPublic

Authored by btrahan on Mar 28 2014, 9:11 PM.
Tags
None
Referenced Files
F14050768: D8639.diff
Thu, Nov 14, 8:33 PM
F14039111: D8639.diff
Mon, Nov 11, 3:49 AM
F14023953: D8639.diff
Thu, Nov 7, 4:25 AM
F14005602: D8639.id20548.diff
Sun, Oct 27, 4:34 PM
F14005601: D8639.id20485.diff
Sun, Oct 27, 4:34 PM
F13999808: D8639.diff
Thu, Oct 24, 5:18 PM
F13999049: D8639.diff
Thu, Oct 24, 12:37 PM
F13975019: D8639.id.diff
Fri, Oct 18, 8:21 AM
Subscribers

Details

Summary

the quotes are 'cuz "create" is inferred. Previously, we inferred on "status", but since we set that on "initializeNewTask" instead infer off "title" (aka "name") like most other apps do. Only hairy tweak was to elevate TYPE_TITLE to the most important of all maniphest transactions, which doesn't actually seem too unreasonable if not correct even? Fixes T4686.

Test Plan

made a new task, used bin/mail, got the right headers (mail vary prefix == created)

Diff Detail

Repository
rP Phabricator
Branch
T4686
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

btrahan retitled this revision from to Fix maniphest "create" transactions.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, this seems cleaner and more consistent to me.

This revision is now accepted and ready to land.Mar 28 2014, 10:28 PM
btrahan updated this revision to Diff 20548.

Closed by commit rP69b8f56cda1c (authored by @btrahan).