Page MenuHomePhabricator

Provide a real object ("PhabricatorRepositoryPushEvent") to represent an entire push transaction
ClosedPublic

Authored by epriestley on Mar 26 2014, 2:58 AM.
Tags
None
Referenced Files
F14014081: D8615.diff
Sat, Nov 2, 9:48 PM
F14013246: D8615.id20440.diff
Sat, Nov 2, 2:40 AM
F14013245: D8615.id20450.diff
Sat, Nov 2, 2:40 AM
F13993479: D8615.diff
Tue, Oct 22, 11:06 PM
F13993464: D8615.id.diff
Tue, Oct 22, 11:01 PM
F13993463: D8615.id20440.diff
Tue, Oct 22, 11:00 PM
F13993457: D8615.id20450.diff
Tue, Oct 22, 10:58 PM
F13989258: D8615.diff
Mon, Oct 21, 7:19 PM
Subscribers

Details

Summary

Ref T4677. Currently, we record individual actions in a push as PhabricatorRepositoryPushLogs, but tie them together only loosely with a transactionKey.

Provide a real PushEvent object, and move some of the denormalized fields to it. This primarily just gives us more robust infrastructure for building, e.g., email about pushes, for T4677, since we can act on real PHIDs rather than passing awkward identifiers around.

Test Plan
  • Performed migration.
  • Looked at database for consistency.
  • Browsed/queried push logs.
  • Pushed a bunch of stuff.

Diff Detail

Repository
rP Phabricator
Branch
pushlog1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Provide a real object ("PhabricatorRepositoryPushEvent") to represent an entire push transaction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 26 2014, 6:05 PM
epriestley updated this revision to Diff 20450.

Closed by commit rPa5f55d506f46 (authored by @epriestley).