Differential D8614

Downgrade accepts on "request changes", and make sticky accepts optional
ClosedPublic
Actions

Authored by epriestley on Mar 25 2014, 10:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 8:06 AM

	Unknown Object (File)
	Wed, Dec 11, 8:02 AM

	Unknown Object (File)
	Tue, Dec 10, 4:40 PM

	Unknown Object (File)
	Tue, Dec 3, 10:46 AM

	Unknown Object (File)
	Fri, Nov 29, 6:49 PM

	Unknown Object (File)
	Fri, Nov 29, 2:47 PM

	Unknown Object (File)
	Thu, Nov 28, 7:00 AM

	Unknown Object (File)
	Nov 20 2024, 9:13 PM

Subscribers

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPed2e12047af4: Downgrade accepts on "request changes", and make sticky accepts optional

Summary

Fixes T3202. This fixes a couple of workflow issues:

Accepted Revision -> Request Review. Currently this stays "accepted" due to sticky rules being too aggressive, but should transition to "needs review".
Accepted Revision -> Plan Changes -> Request Review. Currently this stays "accepted". I think this behavior is correct, and have retained it. (In this case, you don't update the revision, you just "undo" your plan changes.) You can "Request Review" again to get back to "Needs Review".

Then implements a "sticky accept" switch:

When off, updates downgrade accepts.
When off, "request review" always downgrades accepts.

Test Plan

Went through all (I think?) of the plan changes / request review / accept / update workflows, with sticky accept on and off.

Diff Detail

Repository

Branch

diff2

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20426.Mar 25 2014, 10:07 PM

epriestley retitled this revision from to Downgrade accepts on "request changes", and make sticky accepts optional.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley.Mar 25 2014, 10:07 PM

btrahan accepted this revision.Mar 25 2014, 10:35 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 25 2014, 10:35 PM

Closed by commit rPed2e12047af4 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

config/

PhabricatorDifferentialConfigOptions.php

19 lines

editor/

DifferentialTransactionEditor.php

44 lines

docs/

user/

userguide/

differential_faq.diviner

38 lines

Diff 20426

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/docs/user/userguide/differential_faq.diviner

Loading...