Restore psyduck to his proper place
ClosedPublic
Actions

Authored by epriestley on Mar 22 2014, 6:09 PM.

Tags

None

Referenced Files

	F15526449: D8594.diff
	Mon, Apr 21, 9:02 PM

	F15524030: D8594.diff
	Mon, Apr 21, 5:32 AM

	F15491262: D8594.id20380.diff
	Sat, Apr 12, 1:05 AM

	F15476945: D8594.diff
	Mon, Apr 7, 10:17 AM

	F15462071: D8594.id20380.diff
	Tue, Apr 1, 12:47 PM

	F15462070: D8594.id20379.diff
	Tue, Apr 1, 12:47 PM

	F15462069: D8594.id.diff
	Tue, Apr 1, 12:47 PM

	F15435711: D8594.id20380.diff
	Tue, Mar 25, 9:53 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4665: Default Pysduck in the main header is missing

Commits

Restricted Diffusion Commit
rP9c872749a05e: Restore psyduck to his proper place

Summary

Fixes T4665. The "attachable" logic was a little off after a recent change.

Test Plan

With and without a profile image, viewed a page.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20379.Mar 22 2014, 6:09 PM

epriestley retitled this revision from to Restore psyduck to his proper place.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T4665: Default Pysduck in the main header is missing.

Herald added a subscriber: epriestley.Mar 22 2014, 6:09 PM

chad accepted this revision.Mar 22 2014, 6:28 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 22 2014, 6:28 PM

Closed by commit rP9c872749a05e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

8 lines

Diff 20380

View Options

src/applications/people/storage/PhabricatorUser.php

Restore psyduck to his proper placeClosedPublicActions