Differential D8584

Add config validation for task status config
ClosedPublic
Actions

Authored by epriestley on Mar 21 2014, 1:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 2:19 AM

	Unknown Object (File)
	Fri, Nov 22, 10:42 PM

	Unknown Object (File)
	Fri, Nov 22, 10:41 PM

	Unknown Object (File)
	Tue, Nov 19, 4:28 AM

	Unknown Object (File)
	Thu, Nov 14, 5:52 AM

	Unknown Object (File)
	Thu, Nov 14, 3:49 AM

	Unknown Object (File)
	Tue, Nov 12, 10:24 PM

	Unknown Object (File)
	Tue, Nov 12, 9:15 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T1812: Allow for arbitrary values for task status

Commits

Restricted Diffusion Commit
rP7713fb5d99a3: Add config validation for task status config

Summary

Ref T1812. This still doesn't expose configuration to the user, but adds validation for it.

Test Plan

Added a pile of unit tests.

Diff Detail

Repository

Branch

task6

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20362.Mar 21 2014, 1:38 PM

epriestley retitled this revision from to Add config validation for task status config.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1812: Allow for arbitrary values for task status.

Herald added a subscriber: epriestley.Mar 21 2014, 1:38 PM

epriestley added inline comments.Mar 21 2014, 1:40 PM

src/applications/maniphest/constants/ManiphestTaskStatus.php
157	This relaxes things a little bit: if you configure "silly" statuses as special statuses, they'll still work even in serious business mode. This saves us from some awkward situations and more complex validation, and seems fundamentally reasonable.

btrahan accepted this revision.Mar 25 2014, 7:21 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 25 2014, 7:21 PM

Closed by commit rP7713fb5d99a3 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

maniphest/

constants/

ManiphestTaskStatus.php

137 lines

__tests__/

ManiphestTaskStatusTestCase.php

114 lines

Diff 20362

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/constants/ManiphestTaskStatus.php

Loading...

src/applications/maniphest/constants/tests/ManiphestTaskStatusTestCase.php

Loading...